Missing CKEditor when translating email templates

Created on 27 August 2024, 3 months ago
Updated 12 September 2024, 2 months ago

Problem/Motivation

Not sure if this belongs to easy_email or if it's a general config translation issue which may rather be for core?

The problem is that we have the CKEditor in email templates for the HTML body. When translating such templates, a popup is opened with the English text on the left and a simple text area for the translation on the right. This requires us to edit the html tags as well. This is causing issues and is certainly not useable for end users.

Proposed resolution

Not sure what could be done about it, hoping for suggestions.

πŸ“Œ Task
Status

Fixed

Version

3.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jurgenhaas
  • Status changed to Closed: duplicate 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States zengenuity

    I think this is a duplicate of this issue: ✨ Improve Translation User Interface Active . Your mention of CKEditor is more specific, but I intended that as part of the other issue of reusing our existing form for translations.

    I'm not managing any multilingual sites at this time, so I'm unlikely to find time to address this anytime soon. But, I will definitely review and accept any patches if someone else wants to tackle the issue.

  • Status changed to Active 2 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Well, I can see that you want to change the config translation in general. While this may be an option for easy email, I'm uncertain if that's really worth the effort, since having that UI maintained by core is a huge benefit.

    The missing CKEditor in the config translation isn't actually a translation UI issue, it's a mistake in the config schema. I'm going to propose a fix in an MR. It's really simple and it fixes the problem right away.

  • Status changed to Needs review 2 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen
  • Status changed to Needs work 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States zengenuity

    Okay, I'm on board with making this change. However, it doesn't seem like it totally works correctly. Here is what I see on the translation form in Drupal 10 now:

    Is that correct? Why there is a CkEditor on the left side? It allows you to enter text into it, but it just ignores it. The one on the right seems to work. Is this how it's supposed to be, or is it a core bug?

    If this is how these always work, then it's fine. I just want to make sure we're not doing something wrong. I don't work with multilingual sites regularly, and I'm not familiar with what's normal.

  • Status changed to Needs review 2 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    This is a core issue, most likely caused by the fact that CKEditor 5 doesn't allow the read-only flag any longer. That worked for earlier version, but not now. I've spoken to @tstoeckler about this yesterday, he was even the one who brought up the idea of the schema error, and he confirmed that the display of the editor also for the source is caused by core and should be ignored for now.

  • Pipeline finished with Skipped
    2 months ago
    #281146
  • Status changed to Fixed 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States zengenuity

    Okay, sounds good. Merged. Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024