Contrib.social

Enforce 'eager' image loading

Open on Drupal.org →
Created on 27 August 2024, 7 months ago

Problem/Motivation

The current implementation is unsetting $variables['attributes']['loading'], but during testing, we noticed that when the loading attribute is removed, somehow, 'lazy' is (re)added by default. (even for responsive image styles that use 'eager'). Hence, the pdf generation doesn't work (it returns a timeout error) as the above causes an issue when the service renders /pdf.

Steps to reproduce

Attach an image (independently of the loading setting used) on your content and try to generate a PDF.
If you inspect /pdf view, you can notice that the image is using 'lazy' loading.

Proposed resolution

replace the line unsetting the loading attribute unset($variables['img_element']['#attributes']['loading']); with actually enforcing 'eager', i.e., 

$variables['img_element']['#attributes']['loading'] = 'eager';

Remaining tasks

Open MR and provide fix.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom andreastkdf

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024