Remove obsolete EntityReferenceRevisionsFieldItemList::processDefaultValue()

Created on 26 August 2024, 4 months ago
Updated 29 August 2024, 4 months ago

Problem/Motivation

EntityReferenceRevisionsFieldItemList::processDefaultValue() duplicates
EntityReferenceFieldItemList::processDefaultValue() without actually changing any logic.

Steps to reproduce

-

Proposed resolution

Remove it.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tstoeckler
  • Status changed to Needs review 4 months ago
  • 🇩🇪Germany tstoeckler Essen, Germany

    Did some very light Git archeology but wasn't able to find anything interesting. As far as I can tell this was duplicate already 9 years ago when it was introduced.

    Also included the removal of a missing & unused use statement, but as a separate commit in case that's considered out of scope.

  • Pipeline finished with Success
    4 months ago
    Total: 166s
    #265187
  • 🇨🇭Switzerland berdir Switzerland

    It is a duplicate right now, but maybe it shouldn't be? This does the lookup only by uuid, but we also store the revision id. the revision uuid field never landed in core, so it's difficult to replicate what the regular ER field does for revisions.

    I think an ERR field with a default would be extremely rare, no idea what the use case for that would be, so we can maybe just ignore that.

Production build 0.71.5 2024