- Issue created by @kevinvb
- Merge request !61Update ClusterSchemaTest.php - make setup function protected → (Open) created by Unnamed author
- Status changed to Needs review
8 months ago 2:11pm 26 August 2024 - First commit to issue fork.
- Status changed to Needs work
8 months ago 9:55am 28 August 2024 - 🇫🇮Finland sokru
Thanks @kevinvb for working on this issue, it still needs more work to complete the PHPUnit tests on 8.x-7.x. In the past I have spent several days trying to fix the PHPUnit tests on 8.x-7.x branch, but its rather complicated. I'm happy to commit the MR once the PHPunit job passes.
On general level, the current maintainers hope that people would swift to use 8.0.x branch, where the test coverage is better and CI pipelines are green.
- 🇧🇪Belgium kevinvb
At least with the latest state they run. It still alot of red but if you wish to run PHPunit tests it is possible.
I know maintainer wants to push to the 8.0 branch and this branch is only security and bug fixes but if you have tests that all fail isn't that a bug? - 🇫🇮Finland sokru
The tests have never passed on, not even during the DrupalCI times, so arguable if this issue should be on bug or task category. Here's the link for previous attempt to fix the tests https://git.drupalcode.org/project/elasticsearch_connector/-/merge_reque...
And like I said if someone is able to make the tests pass, I'm happy to commit the MR.