- Issue created by @TR
- Merge request !162Issue #3470199 by TR: Update Drush commands for Drush 12+ โ (Open) created by TR
- ๐บ๐ธUnited States TR Cascadia
There are no actual tests for the Drush commands, so the only things the tests will show are issues brought up by cspell, eslint, phpcs, and phpstan. Indeed, phpcs shows there was 1 missing space character. Fixed that.
You can see from the changes that none of the actual command methods were modified, so they work exactly as they did before. The only thing in the patch that had a potential to cause problems was adding the parameter and return type hints, and declaring strict_types. But there were no errors in the above tests. However, each command should be manually tested to ensure there are no runtime typing problems.
- Status changed to Needs review
22 days ago 6:10am 26 August 2024 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
drunken monkey โ made their first commit to this issueโs fork.
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks a lot for creating this issue, I had completely missed those changes in Drush. Also thanks a lot for already providing an MR with the necessary changes.
I manually ran all the commands, and also viewed their help, and made two fixes: one arguably unrelated one to the inner workings of thesapi-i
command, the other just adding descriptions for all the arguments.
Please test/review, if no-one objects I think Iโll just merge this in a week or so.