Update Drush commands for Drush 12+

There are no actual tests for the Drush commands, so the only things the tests will show are issues brought up by cspell, eslint, phpcs, and phpstan. Indeed, phpcs shows there was 1 missing space character. Fixed that.

You can see from the changes that none of the actual command methods were modified, so they work exactly as they did before. The only thing in the patch that had a potential to cause problems was adding the parameter and return type hints, and declaring strict_types. But there were no errors in the above tests. However, each command should be manually tested to ensure there are no runtime typing problems.

drunken monkey → made their first commit to this issue’s fork.

Thanks a lot for creating this issue, I had completely missed those changes in Drush. Also thanks a lot for already providing an MR with the necessary changes.
I manually ran all the commands, and also viewed their help, and made two fixes: one arguably unrelated one to the inner workings of the sapi-i command, the other just adding descriptions for all the arguments.
Please test/review, if no-one objects I think I’ll just merge this in a week or so.

It doesn't seem right to RTBC my own patch, but I've looked at the changes you made and verified I missed the Arguments attributes and verified that you've added them correctly. So I think as far as I'm concerned this is ready to commit.

Good to hear, thanks for reporting back!
Merged.
Thanks again!

Automatically closed - issue fixed for 2 weeks with no activity.