Over 1200 API call limit not reset after 5 minutes

Created on 23 August 2024, 4 months ago

Updated 29 August 2024, 4 months ago

Problem/Motivation

After the Cloudflare 5 minute rate limit is exceeded, the API call count does not get reset after 5 minutes has passed. It stays at 1200, and no further Cloudflare purges are possible.

Steps to reproduce

In a test environment, exceed the 5 minute API call limit. You can do this by setting the Drupal State variable, cloudflare_api_rate_count, to 1200. See that further attempts to purge result in logging the error, "ERROR: CloudFlare - Api Rate limit check.: Exceeded Api limit of 1200/1200 every 5 minutes."
In the Admin UI, go to Configuration -> Development -> Performance -> Purge
Expand "Queue" on the left.
Under the "Queue" column, click the dropdown for "Database".
Select "Empty" and confirm that you want to empty the queue.
Do some actions on the site that will result in queueing more purge items.
Wait 5 minutes, and run purge again. See that your newly queued items have not been processed. Instead you continue to see the "Exceeded Api limit of 1200/1200 limit" message logged.

Proposed resolution

Find out where the cloudflarepurger submodule determines whether or not to reset the 5-minute API count, debug, and fix the logic. Then submit a patch.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

🇺🇸United States anthonyf

Live updates comments and jobs are added and updated live.

Merge Requests

!23Over 1200 API call limit not reset after 5 minutes
Open
🇺🇸United States anthonyf
updated 4 months ago

Comments & Activities

Issue created by @anthonyf
Comment 4 months ago →
🇺🇸United States anthonyf
Comment 4 months ago →
🇺🇸United States anthonyf
Comment 4 months ago →
🇺🇸United States anthonyf
Adding a patch file. Automated tests for the cloudflarepurger submodule passed. I still need to do end-to-end testing on a site that has Cloudflare purging enabled.
Status changed to Needs review 4 months ago1:38pm 29 August 2024
Comment 4 months ago →
🇺🇸United States anthonyf
I've completed my end-to-end testing on a site with Cloudflare purge enabled. The 5-minute rate limit functionality is working as expected now. The patch for this ticket is ready for review and testing by the community.
Merge request !233469998 Over 1200 API call limit not reset after 5 minutes → (Open) created by anthonyf
Pipeline finished with Failed
4 months ago
Total: 178s
#268427

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024