Over 1200 API call limit not reset after 5 minutes

Adding a patch file. Automated tests for the cloudflarepurger submodule passed. I still need to do end-to-end testing on a site that has Cloudflare purging enabled.

I've completed my end-to-end testing on a site with Cloudflare purge enabled. The 5-minute rate limit functionality is working as expected now. The patch for this ticket is ready for review and testing by the community.

Patch https://www.drupal.org/files/issues/2024-08-26/5min-rate-check-reset-346... → works for us, thanks!

API rate reset happens in the \Drupal\cloudflare\State::incrementApiRateCount(). Cloudflare API state tracking has pretty good test coverage so please start with the test which would highlight the bug.

However I'm not sure that there is a value in it counting recent changes in the API limits actively discussed in ✨ Raise cache tag purge limit Needs work .

I understand the fact that the changes being discussed on https://www.drupal.org/project/cloudflare/issues/3062379 ✨ Raise cache tag purge limit Needs work can make the API Rate Limit check obsolete, but this is still an issue impacting production websites.

While the patch works, I feel like this is not the best way to fix the issue, it's introducing duplicated code, which can be a bit more difficult to maintain in the future.

I'll try to create a merge request with an improved version of it.

The other options I see are to completely remove the check or add a configuration option to disable it. As things stand, there is no way to do any of those without a patch.

For me, the ideal scenario would be to resolve this issue while https://www.drupal.org/project/cloudflare/issues/3062379 ✨ Raise cache tag purge limit Needs work is being discussed.