Coding standards - PHPCS (fix failing pipeline)

FILE: ..._submit/web/modules/custom/hide_submit/src/Service/HideSubmitFormAlter.php -------------------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES -------------------------------------------------------------------------------- 11 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) 17 | ERROR | Missing member variable doc comment | | (Drupal.Commenting.VariableComment.Missing) 18 | ERROR | Missing member variable doc comment | | (Drupal.Commenting.VariableComment.Missing) 19 | ERROR | Missing member variable doc comment | | (Drupal.Commenting.VariableComment.Missing) 27 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) 33 | WARNING | Line exceeds 80 characters; contains 86 characters | | (Drupal.Files.LineLength.TooLong) 39 | ERROR | Comment indentation error, expected only 1 spaces | | (Drupal.Commenting.InlineComment.SpacingBefore) 55 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) -------------------------------------------------------------------------------- FILE: ..._submit/web/modules/custom/hide_submit/src/Form/HideSubmitSettingsForm.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 13 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) -------------------------------------------------------------------------------- FILE: ...mit/web/modules/custom/hide_submit/src/Controller/HideSubmitController.php -------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------- 10 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) 15 | ERROR | Missing member variable doc comment | | (Drupal.Commenting.VariableComment.Missing) 21 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) 30 | ERROR | Doc comment is empty (Drupal.Commenting.DocComment.Empty) -------------------------------------------------------------------------------- FILE: ...ilds/project/hide_submit/web/modules/custom/hide_submit/hide_submit.module -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 3 | ERROR | Missing short description in doc comment | | (Drupal.Commenting.DocComment.MissingShort) -------------------------------------------------------------------------------- FILE: ...lds/project/hide_submit/web/modules/custom/hide_submit/hide_submit.install -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 5 | ERROR | Doc comment short description must start with a capital letter | | (Drupal.Commenting.DocComment.ShortNotCapital) 6 | ERROR | Doc comment short description must be on a single line, further | | text should be a separate paragraph | | (Drupal.Commenting.DocComment.ShortSingleLine) --------------------------------------------------------------------------------

Comments & Activities

Issue created by @RhiP
Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris
Merge request !4Issue #3469644: Coding standards - PHPCS (fix failing pipeline) → (Merged) created by RhiP
Pipeline finished with Success
4 months ago
Total: 154s
#261486
Status changed to Needs review 4 months ago11:59am 22 August 2024
Comment 4 months ago →
🇬🇧United Kingdom RhiP
I have fixed all outstanding Coding Standards issues flagged by PHPCS: https://git.drupalcode.org/project/hide_submit/-/merge_requests/4
Comment 4 months ago →
🇬🇧United Kingdom RhiP
Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris
Thanks for this @rhip, looks really good, added a few tidy up comments.
Pipeline finished with Success
4 months ago
Total: 151s
#261659
Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris
Thanks @rhip looks good
Status changed to Fixed 4 months ago11:02am 23 August 2024
Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris
Comment 4 months ago →
System Message

aaron.ferris → committed 3b21211b on 1.0.x authored by rhip →
Issue #3469644: Coding standards - PHPCS (fix failing pipeline)
Status changed to Fixed 4 months ago12:51pm 23 August 2024
Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris

Coding standards - PHPCS (fix failing pipeline)

Problem/Motivation

Proposed resolution

Remaining tasks

Merge Requests

!4Coding standards - PHPCS (fix failing pipeline)
Merged

Comments & Activities

Coding standards - PHPCS (fix failing pipeline)

Problem/Motivation

Proposed resolution

Remaining tasks

Merge Requests

!4Coding standards - PHPCS (fix failing pipeline)Merged

Comments & Activities

!4Coding standards - PHPCS (fix failing pipeline)
Merged