NullLogger not implements LoggerChannelInterface

Appears reasonable.

I’ve made this mistake on a couple other modules in the past as the note on which typehint to use was a bit obscured in the API docs.

IIRC this is a final/internal class so change can be done without BC concerns.

Setting needs work as D.O. has migrated fully away from patch files and now uses only Merge Requests for all issues.

More details can be found in https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → on how to work with MR's on project issues.

Hi @cmlara
thank you for the feedback, and I apologize for the mistake. I've opened the Merge Request to address the issue, which you can find here: https://git.drupalcode.org/project/s3fs/-/merge_requests/64.

Thank you for converting to an MR as it makes the review significantly easier.

Looks good to me. Merged to Dev.

Automatically closed - issue fixed for 2 weeks with no activity.