- Issue created by @ajay_reddy
- Merge request !172Resolve #3469273 "Add event for scheduler finish" β (Open) created by ajay_reddy
- Status changed to Postponed: needs info
7 months ago 1:20pm 22 August 2024 - π¬π§United Kingdom jonathan1055
Hi ajay_reddy,
This is an interesting idea, but I have several concerns and question:- Scheduler already provides an event for each time an entity is processed in a cron run. I am not sure of the benefit of having another event at the end
- The individual events have the entity that has been processed, but your new event will not know anything about which entities have been processed, so I'm not sure how useful it is
- The new event is being dispatched at the end of cron run, regardless of whether Scheduler actually processed any entity. That is a lot of overhead, and gives no real benefit
- The event has a boolen parameter, defaulting to TRUE, but it is not explained what this means, or when it would be FALSE
- All new features should have test coverage so that we can see that it is working and does what is intended
I'm not saying no, but I am also not yet convinced that we need this.
Jonathan