Fix flybox malfunctions after being closed for the first time

Created on 19 August 2024, 5 months ago
Updated 27 August 2024, 5 months ago

Problem/Motivation

after Flybox is closed for the first time the Flybox flickers opening and then immediately closes.

Steps to reproduce

  • Select the Blazy-Flybox formatter for video/remote video.
  • Click to open the video.
  • Close it using the Blazybox__close button.
  • Reopen it and observe the issue.

Proposed resolution

I found out the issue raises from $el.on('transitionend', transitioning); and $el.off('transitionend', transitioning); it seems that $el.off doesn't work properly for some reason when I changed $el.on('transitionend', transitioning); to $el.one('transitionend', transitioning); it worked like a charm.

i Also fixed the flicker of starting the video where Flybox begins from top to bottom to top again by transferring transition: transform 0.6s, min-height 0.6s; to a different selector

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

3.0

Component

Code

Created by

🇯🇴Jordan Ahmad Khader

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024