Regression: entity, flag, flagging tokens removed without notice

Looks like in https://git.drupalcode.org/project/eca_flag/-/commit/8ba776511c935bb0032... , the tokens used to be defined in a BeforeInitialExecutionEvent hook, which added them directly to the token service -- this code got removed/moved into a BuildEventData() method on the event plugin.

I'm not exactly sure how this is supposed to be different -- do we need to add a getData() method, and return a DTO for the request key?

Not sure if this is the correct approach -- but it's working at least for getting "entity" passed. I'm not seeing "flag" or "flagging" showing up in the logs -- however, using [flag:name] did appear to resolve and work correctly.

I did try wrapping these in DataTransferObject::create(), but that did not work.

This does appear to fix my models?

The MR fails testing. I've left a couple of comments there, which should help to resolve those.

What seems to be missing is the flaggings (plural) token, please add that as well.

In addition to that, do we also have to remove the not working tokens from the buildEventData method?

Ok addressed the issues with the test failures.

Regarding removing from the buildEventData, seems like we should do that -- I was wondering if the annotations in the PHP attributes should be copied up to the getData ones? Specifically it has classes, and properties on the flaggings annotation -- are these correct, things we should add?

Yes, we should move the more detailed attributes to the getData method, as they express more correctly which tokens are available for which events. That's important for the documentation in ECA Guide.

Also, the tests are still failing!

Has any progress made on this issue? This upgrade renders my entire site unusable - and I have too many complex models with flag elements to rebuild them all from scratch.

jurgenhaas → changed the visibility of the branch 2.1.x to hidden.

This code change is looking good to me now. Someone needs to test if the MR fixes the problem on their site and set this to RTBC, we can then move it forward.

Ah, that's good news. I don't think I have bandwidth to test this weekend but I'll get it into my schedule as soon as I can, unless someone else gets to it first.

I ran into this issue after a fresh upgrade to ECA 2.x and the patch fixed the issue for me.

Thanks very much, I have a bunch of flag related models that were all affected.

I take that previous comment as an RTBC and merged and back ported this fix.

Great, happy to be that trigger. Thanks again for the great work.

Works for me. Thanks to both of you for resolving this.

Automatically closed - issue fixed for 2 weeks with no activity.