PHPCS not catching multiple spaces after final keyword

Created on 15 August 2024, 6 months ago

Updated 2 September 2024, 5 months ago

Found a formatting issue not being caught with PHPCS by adding multiple spaces between final and public.

Add final to a public function with multiple spaces. Example:

  final      public static function create(ContainerInterface $container) {

Update appropriate standards.

🐛 Bug report

Status

Active

Version

3.8

Component

Coder Sniffer

Created by

🇺🇸United States michalsen

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @michalsen
Comment 5 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Thanks for reporting! Created upstream fix: https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/604

Not sure if we should fork this into Coder in the meantime.
Comment 5 months ago →
fredden
> Not sure if we should fork this into Coder in the meantime.

This shouldn't be necessary since PHP_CodeSniffer is being actively maintained again now. I don't see any reason this fix couldn't make it into the next minor / feature release.

Production build 0.71.5 2024