Old content is cached after modifying CE display

Created on 15 August 2024, 4 months ago
Updated 1 September 2024, 4 months ago

Steps to reproduce

Render something (e.g. a teaser in a list somewhere

Change the CE display

Reload the thing. Content should be changed.

Note

I haven't doublechecked whether it's something in our distribution, but I suspect not. I suspect CustomElementGenerator just needs to add the CE display config entity as cacheable dependency.

Just adding this issue here now to get the list complete.

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @roderik
  • Assigned to junkuncz
  • Status changed to Needs work 4 months ago
  • 🇭🇺Hungary junkuncz Budapest
  • Merge request !80Fixing CE cache dependency → (Merged) created by junkuncz
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • 🇭🇺Hungary junkuncz Budapest
  • Pipeline finished with Success
    4 months ago
    Total: 370s
    #256552
  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Great, thanks for testing / fixing!

    I'm also adding it inside the "else" of buildEntityContent(), when the CE display is disabled. Because when it is enabled again, the same cache tags should be cleared.

    But I can do that at the same time as a quick test.

  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Two things:

    1. My previous comment was dumb. In the "else", there IS no CE display, so you also cannot add it.

    2. This is incomplete.

    • Suppose you build a list of stuff in "teaser" view mode -- and the "teaser" CE display is not enabled, so it's using the default CE display.
    • If this default CE display is edited, then caches for this list should be flushed. OK.
    • If the "teaser" CE display is created/saved, then caches for this list should also be flushed, because they should be rebuilt with the new display. This did not happen yet.

    So, cache tags should be added for both cases.

    I figured it would be better to do this instead of setting needs work. Please review current status.

  • Status changed to RTBC 4 months ago
  • 🇭🇺Hungary junkuncz Budapest

    Works well, good to go!

  • Pipeline finished with Skipped
    4 months ago
    #257300
  • Status changed to Fixed 4 months ago
  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024