- Issue created by @jonathan1055
- Merge request !170Issue #3468320 Date fields not found for Commerce Product in SchedulerNonEnabledTypeTest → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
The problem is that the 'product variant types' checkbox used to be ticked by default, but now it is not, which caused the "save" to fail, and hence the rest of the test failed.
The test is now improved to check that the save is successful, as that will highlight the actual problem. All entity types will be protected for this kind of future change.
- Status changed to Needs review
7 months ago 4:31pm 21 August 2024 - 🇬🇧United Kingdom jonathan1055
We now get the more helpful test failure message
Drupal\Tests\scheduler\Functional\SchedulerNonEnabledTypeTest::testNonEnabledType with data set "#commerce_product-2" (2, 'commerce_product', 'non_enabled_product', 'Disabling both settings', false, false) An element matching xpath "//div[@data-drupal-messages]//div[@aria-label="Error message"]" appears on this page, but it should not. /builds/project/scheduler/web/core/tests/Drupal/Tests/WebAssert.php:838 /builds/project/scheduler/tests/src/Functional/SchedulerNonEnabledTypeTest.php:48
See https://git.drupalcode.org/project/scheduler/-/jobs/2506875#L485
-
jonathan1055 →
committed 3afe836d on 2.x
Issue #3468320 by jonathan1055: Commerce test fails - cannot save...
-
jonathan1055 →
committed 3afe836d on 2.x
- Status changed to Fixed
7 months ago 10:47am 22 August 2024 - 🇬🇧United Kingdom jonathan1055
Next Major tests all pass
https://git.drupalcode.org/project/scheduler/-/jobs/2518751#L660
Merged and fixed. Automatically closed - issue fixed for 2 weeks with no activity.