Section background color not updated in the instant preview

Created on 15 August 2024, 3 months ago

Problem/Motivation

When changing background color of a section in the sidebar, the change does not reflect on the page unless the Update button is pressed.

Steps to reproduce

Install latest version of Drupal 10 (currently 10.3.2).
Install bootstrap_styles, bootstrap_layout_builder, and layout_builder_blocks.
Create a new content type and enable Layout Builder for its default view display mode.
Add Bootstrap 1 Col section and create a content block with sample text in it.
Press "Configure Section ...", and on Style tab set any background color.

Expected behavior

Background color of the section get updated right after clicking any option in the Background color list.

Actual behavior

Background color of the section does not get updated when options in the Background color list are clicked, until the Update button is pressed. Also, if any background color was already selected for the section, it gets removed from the section until the Update button is pressed.

Proposed resolution

Fix logic for checking if the background type is image or video.

Current logic checks if $group_elements['background_video'] or $group_elements['background_image'] is not an empty string. This check always passes since these elements are arrays. This causes the video background to be incorrectly recognized when only the background color is set.

🐛 Bug report

Status

Needs review

Version

1.1

Component

Code

Created by

🇷🇺Russia iamweird

Live updates comments and jobs are added and updated live.

Merge Requests

!66Section background color not updated in the instant preview
Open
🇷🇺Russia iamweird
updated 3 months ago

Comments & Activities

Issue created by @iamweird
Merge request !66Issue #3468298: Fix background color not updated instantly when changed in Configure section drawer → (Open) created by iamweird
Comment 3 months ago →
🇷🇺Russia iamweird
Comment 3 months ago →
🇷🇺Russia iamweird
I'm not sure if old check of $group_elements['background_image'] and $group_elements['background_video'] for empty string is ever valid or should be preserved for a historical reason e.g. to make layouts made with previous versions work correctly.

However, I decided to change check here to is_numeric instead of comparison with empty string to better reflect actual expectation of a media ID. Advice on this matter is welcome from anyone who knows the module architecture well.
Status changed to Needs review 3 months ago11:30am 15 August 2024
Comment 3 months ago →
🇷🇺Russia iamweird

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024