- Issue created by @Drupal Learn
- Status changed to Closed: works as designed
5 months ago 1:12am 20 August 2024 - 🇺🇸United States drumm NY, US
https://github.com/keycloak/keycloak/issues/22067 and the related pull request is where this was implemented. I can’t speak for the Keycloak project, but I expect their goal was for the button to show what it does, not the current state. If there is a best practice showing this could be done better, I recommend opening an issue with the Keycloak project.
I did a super quick survey of the first three sites I happened to think of:
- accounts.google.com - has a show password checkbox
- GitHub.com - no show password functionality
- GitLab.com - matches accounts.drupal.org’s current behavior
- 🇬🇧United Kingdom jonathan1055
I agree that there is no problem here and this issue can be Closed WAD.
the password reveal icon should show the password only when the icon is in a open state not when it is closed(struck out)
I know that there can be two ways to interpret icons like this, and it seems to me to be a common problem in many UIs. The quesion is "Does the icon/button/slider/switch indicate what the state of the option is now, or what it will do when it is clicked/tapped/pressed"
From other examples of revealing passwords, the button is saying "this is what will happen if you press me", in this case "press the open eye to see what you get with an open eye (it reveals the pw)". The icon is not showing what has already happened, the current state. It is showing what the future state will be when you engage with it. So I think there is no problem here.
... and the full thread on Slack is https://drupal.slack.com/archives/C51GNJG91/p1723669955390359