Fit current form onto config format, remove duplicate-name check

Created on 14 August 2024, 5 months ago
Updated 28 August 2024, 4 months ago

This MR

  • removes all the duplicate-name-checking logic, and the changes in the copyFormValuesToEntity() flow that was hacked into the form (and not complete) to achieve it
  • reinstates "fixed form-row values as component keys" (which I should have done instead of the first point)
  • converts the components from 'current schema' to 'current temporary form row format' on entity load, and back on entity save.

All issues with renaming components that I tried and failed to fix in the current state of 📌 Change configuration structure for CE display 'components' Active are now gone. It is possible to enable a component, disable it, rename it, then change its form setting, then rename it again, and then save... and things are saved as intended.

Also, 'current' CE display objects (in e.g. our own internal project) are saved without changes, when I load-and-save the form.

(What remains is an issue related to Core JS / field-form that forces us to 'TAB away' from the "key" input, before saving. That was present already and will be fixed in 📌 Simplify entity-ce-display form and AJAX logic Active .)

This implements what I planning in comment #3455435-13: Change configuration structure for CE display 'components' .

If you think the conversion logic that I introduced instead of the copyFormValuesToEntity() mess, is still ugly/unstable... then

  • Please specify the reason in terms not related to the ugliness that will be removed in the revamped UI 📌 Simplify entity-ce-display form and AJAX logic Active .
  • Changing this logic and the configuration format is separate from the UI revamp.
  • The UI revamp is most urgent right now.
  • So I would really like to discuss this after stabilizing the UI.

So: this is my plea to commit this now, regardless whether you still want to change the config format (regardless of me hoping that this may convince you not do pursue that config change).

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024