Move GraphQL development to drupal.org to leverage issue credits

Open on Drupal.org →

Created on 9 August 2024, 4 months ago

Updated 30 August 2024, 4 months ago

Problem/Motivation

A couple of years ago development for this module started on Github because there were no pull requests on drupal.org. That has changed, we have merge requests on drupal.org now and a flexible Gitlab CI runner system.

More importantly we cannot assign issue credits on Github. Contributors and companies do not receive visibility through the credit system on drupal.org right now.

We could move development back to drupal.org, let's discuss pros and cons here.

Pros:

We can give contributors proper drupal.org credits
We integrate better with the rest of the Drupal ecosystem (moving issues for example between Drupal projects)
Simpler release process, only on drupal.org

Cons:

We need to port our Github Action CI process to Gitlab
Gitlab UI is less usable than Github
We lose exposure to the wider Github developer community (I don't think this matters much, most contributors have drupal.org accounts)
We need some workflow to generate the documentation pages (maybe keep doing that on Github here?)
Gitlab does not allow routing of notification emails to different email addresses per project

I will try to port the test execution to Gitlab in a drupal.org sandbox, let's see how hard that is.

Original discussion https://github.com/drupal-graphql/graphql/issues/1411

Remaining tasks

1. find some Github action that auto-closes new Github issues and pull requests, pointing people to drupal.org
2. Make some artificial drupal.org issues to give credit for some of the most recent contributions

🌱 Plan

Status

Active

Version

4.0

Component

Miscellaneous

Created by

🇦🇹Austria klausi 🇦🇹 Vienna

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!3Move GraphQL development to drupal.org to leverage issue credits
Merged
🇦🇹Austria klausi
updated 4 months ago

Comments & Activities

Issue created by @klausi
Comment 4 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Started the move:
1. Enabled issues at https://www.drupal.org/project/issues/graphql?categories=All →
2. Removed Github actions for testing and mirroring
3. Enabled auto mirror from drupal.org to Github
4. Assigned first issue credit to myself for making the move https://www.drupal.org/project/graphql/issues/3467189 📌 Implement automated testing on drupal.org Gitlab Fixed

TODO:
1. find some Github action that auto-closes new Github issues and pull requests, pointing people to drupal.org
2. Make some artificial drupal.org issues to give credit for some of the most recent contributions

Comment 4 months ago →

klausi → committed 80571b03 on 8.x-4.x

chore(github): Add Github action to auto-close github issues (#3467196)

Comment 4 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Implemented Github actions to close issues an PRs.

TODO:
1, Fix PHPStan and PHPCS in d.-o testing
2. Make some artificial drupal.org issues to give credit for some of the most recent contributions
Merge request !3test(phpstan): Fix PHPstan check → (Merged) created by klausi
Comment 4 months ago →
System Message

klausi → committed 7c714fff on 8.x-4.x
test(phpstan): Fix PHPstan check (#3467196)
Comment 4 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
I think we are mostly done here for now. I left the old Github issues and pull requests open, but new ones will be closed immediately with a pointer to the drupal.org issues queue. Not sure yet what we should do with them, I'm sure there is relevant stuff there that should be picked up.

I assigned issue credits for all 4.x commits that were done in the year 2024.
Comment 3 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Marking this as done.
Comment 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024