Dependency on facets and search_api

Created on 8 August 2024, 5 months ago

Problem/Motivation

When running ci tests during merge requests errors are reported classes from facets and search_api are missing.
Matomo should declare a dependency on both modules.

------ ---------------------------------------------------------------------- 
  Line   src/HookHandler/ViewsPostRenderHookHandler.php                        
 ------ ---------------------------------------------------------------------- 
  36     Property                                                              
         Drupal\matomo\HookHandler\ViewsPostRenderHookHandler::$facetsManager  
         has unknown class Drupal\facets\FacetManager\DefaultFacetManager as   
         its type.                                                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
  48     Parameter $facetsManager of method                                    
         Drupal\matomo\HookHandler\ViewsPostRenderHookHandler::__construct()   
         has invalid type Drupal\facets\FacetManager\DefaultFacetManager.      
  214    Class Drupal\search_api\Plugin\views\query\SearchApiQuery not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/views/display_extender/Matomo.php                          
 ------ ---------------------------------------------------------------------- 
  47     Property                                                              
         Drupal\matomo\Plugin\views\display_extender\Matomo::$facetsManager    
         has unknown class Drupal\facets\FacetManager\DefaultFacetManager as   
         its type.                                                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
  160    Class Drupal\search_api\Plugin\views\query\SearchApiQuery not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ ---------------------------------------------------------------------- 

Steps to reproduce

Run a merge request on this project.

Proposed resolution

Add a test_dependency on search_api and facets

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium kriboogh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024