Contrib.social

Figure out how to address the ComparisonFailure constructor changes

Open on Drupal.org →
Created on 5 August 2024, about 1 month ago
Updated 22 August 2024, 25 days ago

Describe your bug or feature request.

The constructor of SebastianBergmann\Comparator\ComparisonFailure changed in the version that is pulled with D11. I'm just not sure how to address this?
Should we introduce a ComparisonFailureBridge class that instantiates the SebastianBergmann\Comparator\ComparisonFailure differently based on the Drupal core version? 

 ------ ------------------------------------------------------------------ 
  Line   modules/order/src/Comparator/AdjustmentComparator.php             
 ------ ------------------------------------------------------------------ 
  31     Class SebastianBergmann\Comparator\ComparisonFailure constructor  
         invoked with 6 parameters, 4-5 required.                          
 ------ ------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------ 
  Line   modules/price/src/Comparator/NumberComparator.php                 
 ------ ------------------------------------------------------------------ 
  30     Class SebastianBergmann\Comparator\ComparisonFailure constructor  
         invoked with 6 parameters, 4-5 required.                          
 ------ ------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------ 
  Line   modules/price/src/Comparator/PriceComparator.php                  
 ------ ------------------------------------------------------------------ 
  28     Class SebastianBergmann\Comparator\ComparisonFailure constructor  
         invoked with 6 parameters, 4-5 required.
📌 Task
Status

Fixed

Version

3.0

Component

Developer experience

Created by

🇮🇱Israel jsacksick

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024