- Issue created by @mparker17
- Merge request !29Issue #3465601 part 1: Improve configuration schema and how we use it β (Merged) created by mparker17
- Status changed to Needs review
10 months ago 10:11pm 3 August 2024 - π¨π¦Canada mparker17 UTC-4
Okay, Iβve decided to create a merge request for the βsafestβ change, i.e.: the one that only makes changes that maintain compatibility with Drupal 9.0, i.e.: changing certain types from string to path.
- Status changed to Active
10 months ago 11:54am 6 August 2024 - π¨π¦Canada mparker17 UTC-4
Merging the string β path changes.
Moving back to "Active" for the rest of the proposed changes
-
mparker17 β
committed cbc69f18 on 8.x-2.x
Issue #3465601 part 1: Improve configuration schema and how we use it
-
mparker17 β
committed cbc69f18 on 8.x-2.x
- π¨π¦Canada mparker17 UTC-4
Note that part 1 of this change was released in sitemap-8.x-2.0-beta7 β ; but there are still outstanding parts of this issue to be released in the future.
- πΊπΈUnited States dcam
From my own comment in #3465577-18: Split sitemap_book config schema from sitemap schema β :
I'm guessing that a lot of the
nullable
keys were the result of all plugin settings being lumped into a single array. You had to do that so one plugin could leave all the other settings as empty.While this config improvement is going on, any unnecessary
nullable
properties should be removed. - Status changed to Needs work
12 days ago 3:56pm 26 May 2025 - π¨π¦Canada mparker17 UTC-4
Updating the issue summary: we are unblocked now, so moving to Needs Work.
- π¨π¦Canada mparker17 UTC-4
I split off...
2. If we dropped support for D9 and D10.0 through 10.2, (i.e.: support only D10.3+ and D11.0+ only, we could change
sitemap.settings.plugins.*.weight
from typeinteger
toweight
... into its own issue, π Change sitemap.settings.plugins.*.weight from type integer to weight Postponed ; updating issue summary to say this.
- π¨π¦Canada mparker17 UTC-4
mparker17 β changed the visibility of the branch 3465601-config-schema-2 to hidden.
- π¨π¦Canada mparker17 UTC-4
I split off...
3. If we dropped support for D9 and D10.0 through 10.1 (i.e.: support 10.2+), we could simplify the configuration form by making use of #config_target in our main config form.
... into its own issue, π Start using #config_target in SitemapSettingsForm Active ; updating the issue summary to say this.
- π¨π¦Canada mparker17 UTC-4
I think that, since we've split the remaining tasks into π Change sitemap.settings.plugins.*.weight from type integer to weight Postponed and π Start using #config_target in SitemapSettingsForm Active , we can mark this as fixed.