For excluded paths, programmatically escape unescaped slashes

joakland → changed the visibility of the branch 3465555-for-excluded-paths to hidden.

Whoops, sorry about the accidental merge request !126, from the wrong branch. As you probably figured out already, !127 is the correct one.

did a short review:

-    $path = rtrim($this->context->getPathInfo(), '/');
+    $path = trim($this->context->getPathInfo(), '/');

is there a reason for this change ? since this was a fix for: https://www.drupal.org/project/easy_breadcrumb/issues/3271576 🐛 Paths to replace with custom breadcrumbs is broken for Fixed

i can see that a starting slash could add an extra empty element into $paths_elements but this could be solved with

      $clean_path_elements = array_filter ($path_elements, function($var){ return ($var !== NULL && $var !== FALSE && $var !== "");});
      $check_path = '/' . implode('/', $clean_path_elements);

to keep $path_elements in the shape it is used later on in the code... and have the $checkpath the code needs...

and this ?

-      $internal_path = $route_match->getRouteObject() ? Url::fromRouteMatch($route_match)->getInternalPath() : '';
+      $internal_path = Url::fromRouteMatch($route_match)->getInternalPath();

it was a fix for: https://www.drupal.org/project/easy_breadcrumb/issues/3463616 🐛 InvalidArgumentException repeatedly thrown when running cron via drush Fixed

Here I see no influence on the issue what so ever...since $internal_path is only used by custom paths and has noting to do with excluded paths.

other wise it looks fine... besides the PHPCS issues that the workflow is detecting

spuky → closed merge request !126

The issues you're raising here don't seem to relate to the changes in my fork, so I'm unable to comment . . . unless I'm missing something?

OK, the I've reverted the changes you called out above. TBH I didn't make those changes myself, so I wonder if they were somehow committed to the repo before I forked it? Anyway, My changes should be more obvious now.

did the codestyle cleanup myself

Thanks for your Contribution!!!

Automatically closed - issue fixed for 2 weeks with no activity.