fallbackAwareAppendIfEnabled still has special treatment for 'none'

Created on 2 August 2024, 8 months ago
Updated 16 August 2024, 8 months ago

Problem/Motivation

In 2.0.0, 'none' no longer gets special treatment - in 1.x is would disable/remove other sources.

fallbackAwareAppendIfEnabled does not copy other values to descendent directives as expected if 'none' is present.

Steps to reproduce

1. Set a fallback directive like default-src to 'none' example.com
2. Call fallbackAwareAppendIfEnabled on another directive (e.g. script-src) with an additional value

All of the default source values should be copied to the new directive, but instead only the new value is set.

Proposed resolution

Copy all values from a fallback directive, instead of an empty array.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇨🇦Canada gapple

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024