Integrate tabled library

Created on 1 August 2024, 5 months ago
Updated 13 September 2024, 3 months ago

Problem/Motivation

This plugin is not fully responsive, providing accessible markup and some basic responsive styles. To make it fully responsive, an adaptive JavaScript library needs to be integrated.

Proposed resolution

Integrate the tabled library.

Remaining tasks

  1. Install the tabled library as an extra composer dependency. See the Webform implementation.
  2. Attach the tabled library to pages which utilize the responsive table button.
  3. Initialize the tabled library on the responsive table markup.
  4. Remove data-text attributes from the responsive table module; these are duplicative of functionality in tabled.
  5. Add an option to the responsive table popup to choose the small screen display; either horizontal or stacked.

User interface changes

An additional option to choose either stacked or horizontal small screen display.

API changes

None.

Data model changes

None.

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States bronzehedwick New York

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bronzehedwick
  • πŸ‡ΊπŸ‡ΈUnited States bronzehedwick New York

    After some research here, I actually think the best way to include the tabled dependency is through package.json, instead of through composer. The reason is two fold.

    1. There are already dependencies managed in package.json, so it will keep everything centrally managed.
    2. The composer installation pattern requires a different composer command via the composer merge plugin, which is built for optional dependencies. While the dependency could be optional, I'd argue that this would create more confusion and work for 99% of the use cases, where you just want a fully responsive and accessible table element out of the box.
  • Merge request !2Add tabled β†’ (Merged) created by bronzehedwick
  • πŸ‡ΊπŸ‡ΈUnited States bronzehedwick New York

    @javier I pushed a two-fold fix:

    1. Remove yarn dependency, tracking the tabled library inside this repository. This removes the need for module users to install yarn.
    2. Add a configuration page for end users to change the CSS selector which applies tabled, along with a sensible default.
  • Status changed to Needs work 4 months ago
  • @bronzehedwick it looks great! I left a bunch of comments regarding semantic aspects, once those are resolved I'll test it in my local.

  • Assigned to javi-er
  • Status changed to Needs review 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States bronzehedwick New York

    Thanks @javier! I pushed fixes for the issues you raised, aside from the ones needed in follow ups.

  • Assigned to bronzehedwick
  • Assigned to javi-er
  • πŸ‡ΊπŸ‡ΈUnited States bronzehedwick New York

    @javi-er Finished addressing the feedback you provided. Let me know if there are other changes needed!

  • Status changed to RTBC 4 months ago
  • @bronzehedwick I think this is good to go! I can confirm that the tabled library is being loaded and the selector can be configured.
    There are some styling issues though that can be fixed in a follow up ticket (at least when I test this with a project with custom styles).
    Great job!

  • Status changed to Fixed 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States bronzehedwick New York
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024