- Issue created by @bronzehedwick
- πΊπΈUnited States bronzehedwick New York
After some research here, I actually think the best way to include the
tabled
dependency is throughpackage.json
, instead of through composer. The reason is two fold.- There are already dependencies managed in
package.json
, so it will keep everything centrally managed. - The composer installation pattern requires a different
composer
command via the composer merge plugin, which is built for optional dependencies. While the dependency could be optional, I'd argue that this would create more confusion and work for 99% of the use cases, where you just want a fully responsive and accessible table element out of the box.
- There are already dependencies managed in
- πΊπΈUnited States bronzehedwick New York
@javier I pushed a two-fold fix:
- Remove yarn dependency, tracking the tabled library inside this repository. This removes the need for module users to install yarn.
- Add a configuration page for end users to change the CSS selector which applies tabled, along with a sensible default.
- Status changed to Needs work
3 months ago 7:12pm 8 August 2024 @bronzehedwick it looks great! I left a bunch of comments regarding semantic aspects, once those are resolved I'll test it in my local.
- Assigned to javi-er
- Status changed to Needs review
3 months ago 7:56pm 8 August 2024 - πΊπΈUnited States bronzehedwick New York
Thanks @javier! I pushed fixes for the issues you raised, aside from the ones needed in follow ups.
- Assigned to bronzehedwick
- Assigned to javi-er
- πΊπΈUnited States bronzehedwick New York
@javi-er Finished addressing the feedback you provided. Let me know if there are other changes needed!
- Status changed to RTBC
3 months ago 9:31pm 29 August 2024 @bronzehedwick I think this is good to go! I can confirm that the tabled library is being loaded and the selector can be configured.
There are some styling issues though that can be fixed in a follow up ticket (at least when I test this with a project with custom styles).
Great job!- Status changed to Fixed
3 months ago 1:49pm 30 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.