Contrib.social

Promotion product conditions do not render on initial page load

Open on Drupal.org →
Created on 31 July 2024, 4 months ago

Describe your bug or feature request.

On the promotion edit form, when editing an existing promotion, the product condition field element is not rendered. However, after changing the 'offer type' the conditions field is refreshed and is rendered as expected (if the offer type is product specific).

See attached screenshots.

If a bug, provide steps to reproduce it from a clean install.

- Create a promotion that uses the Buy X get Y offer type
- Select a product variant condition
- complete rest of form and submit
- edit the newly created promotion
- The 'offer type' is selected, but the product conditions element is not.

- Change the 'offer type' to see proper rendering.

🐛 Bug report
Status

Active

Version

2.39

Component

Promotions

Created by

🇺🇸United States mbopp Grand Rapids, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mbopp
  • Status changed to Postponed: needs info 4 months ago
  • Comment 4 months ago →
    🇮🇱Israel jsacksick

    Just tried that and can't reproduce the bug? Could be due to a contrib module or custom code / theme? See the attached screenshot.

  • Comment 2 months ago →
    🇺🇸United States mbopp Grand Rapids, MI

    Thanks. I'll see if I can reduce the issue to another module and report back.

  • Comment about 1 month ago →
    jgonzales20

    We are also affected by this issue. From my observation, I've noticed that this issue only persists with "Additional Offers" type promotions, but it can be worked around with standard "Offer" types.

  • Comment about 1 month ago →
    🇺🇸United States mbopp Grand Rapids, MI

    Hi @jsacksick, we found the issue. A custom module was re-rendering content to create structured data for view listings, causing this conditional block on the promotions edit page to render empty (thinking it was already done for structured data). Why it only affects this markup is unclear, but it doesn’t need resolution in the commerce project.

    Thanks.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024