- Issue created by @nicross-com
- Assigned to itmaybejj
- πΊπΈUnited States itmaybejj
Oof. So this module family creates a pseudo-multisite with multiple domains being served from one DB?
If that is the case, I don't think we should drop the domains from the url -- you'll want them later, to search and filter the API reports. Probably better to rewrite the not-much-better-than-a-placeholder Editoria11y API path validator to accept absolute paths. Maybe that should be replaced with a call to PathValidator or something like that?
This may have some downstream affects on the views as well; that would need to be tested once the API was accepting absolute URLs.
Thanks for considering this. That sounds like it could be a more robust solution than our simple workaround.
The reason why the workaround works for us is because, even with the Domain Source module installed, our path aliases are still required to be unique. So we have aliases like
/domain1/home
and/domain2/home
where the reporting still makes sense to us without a domain present. We also have domain aliases set up for our different environments, like adev.domain1.com
orstaging.domain2.com
, which complicates it further.Granted, we have a lot of custom code gluing this together, so supporting a full URL here might still be the better general solution.
-
itmaybejj β
committed 7573cbe3 on 2.1.x
Issue #3465028 by nicross-com, itmaybejj: Invalid page path when...
-
itmaybejj β
committed 7573cbe3 on 2.1.x
- Status changed to Needs review
2 months ago 8:29pm 9 September 2024 - Status changed to Fixed
2 months ago 7:27pm 16 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- πΊπΈUnited States itmaybejj
Drat -- reopening this as the fix caused a regression that prevents populating reports for sites that are installed in subfolders.
-
itmaybejj β
committed bf2cf03e on 2.2.x
Issue #3465028 by itmaybejj: Invalid page path when <current> is an...
-
itmaybejj β
committed bf2cf03e on 2.2.x
-
itmaybejj β
committed 3622d166 on 2.1.x
Issue #3465028 by itmaybejj: Invalid page path when <current> is an...
-
itmaybejj β
committed 3622d166 on 2.1.x
-
itmaybejj β
committed 58e856fa on 2.1.x
Issue #3465028 by itmaybejj: Invalid page path when <current> is an...
-
itmaybejj β
committed 58e856fa on 2.1.x
-
itmaybejj β
committed 07ab7a10 on 2.2.x
Issue #3465028 by itmaybejj: Invalid page path when <current> is an...
-
itmaybejj β
committed 07ab7a10 on 2.2.x