Contrib.social

PHP deprecation warnings when fetcher result is null

Open on Drupal.org →
Created on 31 July 2024, 8 months ago
Updated 19 August 2024, 8 months ago

Problem/Motivation

When $fetcher_result->getRaw() returns null instead of a string, the following PHP deprecation errors can occur:

  • Deprecated function: mb_detect_encoding(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\feeds_ex\Encoder\TextEncoder->detectEncoding()
  • Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\feeds_ex\Encoder\XmlEncoder->convertEncoding()
  • Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\feeds_ex\Feeds\Parser\ParserBase->prepareRaw()

\Drupal\feeds\Result\FetcherResultInterface::getRaw() is supposed to return a string, but this is currently not enforced, so technically it could return NULL.
I found this out using a fetcher result in a custom module.

Steps to reproduce

  1. Create a class, implement \Drupal\feeds\Result\FetcherResultInterface and make the method getRaw() return NULL instead of a string.
  2. Pass an instance of the class to \Drupal\feeds_ex\Feeds\Parser\ParserBase::prepareRaw().

Proposed resolution

Check if \Drupal\feeds\Result\FetcherResultInterface::getRaw() in \Drupal\feeds_ex\Feeds\Parser\ParserBase::prepareRaw() is a string before passing it along.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands megachriz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024