- Issue created by @ericgsmith
- πΊπΈUnited States cmlara
Observe they are rewritten by the module
I recalled looking at this when we added support for assets:// and thinking βwhy donβt I need to disable this? Links are generating correctly but why?β and convinced myself that it was something with how the file pas passed over and location bypasses changing it to s3fs, I completely missed the script converting relative to absolute.
Do not override asset.css.optimizer if > drupal 10.1?
That would be the best solution.
Simple \Drupal::version < 10.1 comparison before overriding is likely sufficient. - Merge request !62Issue #3464809: Do not override the CSS asset optimizer service if Drupal... β (Merged) created by ericgsmith
- Status changed to Needs review
8 months ago 9:04pm 31 July 2024 - π³πΏNew Zealand ericgsmith
Opened MR with the change from above - it doesn't look like this would be applicable to v4 as the css / js functionality is in a sub module which could just be disabled (I assume - have not tested or looked at the 4.x branch)
- πΊπΈUnited States cmlara
4.x should be fine as it is a submodule and can be enabled/disabled by choice (and there is a good chance Iβm going to remove the code completely once D11 comes out).
- Status changed to Fixed
8 months ago 5:37am 1 August 2024 - πΊπΈUnited States cmlara
Small change by maintainer prior to merging (caused by maintainer direction lacking sufficient detail in initial review).
Thanks for locating this issue. Merging to Dev. Should go out this week when we tag D11 support.
-
cmlara β
committed 07b558e1 on 8.x-3.x authored by
ericgsmith β
Issue #3464809 by ericgsmith, cmlara: Do not override the CSS asset...
-
cmlara β
committed 07b558e1 on 8.x-3.x authored by
ericgsmith β
Automatically closed - issue fixed for 2 weeks with no activity.