Support "0" values without needing to specify a default value.

Created on 30 July 2024, 4 months ago

Updated 17 September 2024, 2 months ago

Problem/Motivation

Sometimes, 0 is a valid value, but it's currently ignored, and can lead to crashes when a webform is submitted.

This is because \Drupal\calculation_fields\CalculationFieldsTrait::buildExpression() can sometimes return NULL when the value is empty.

Steps to reproduce

Attempt to submit a form with a markup element with a 0 value.

Proposed resolution

Add appropriate checks for NULL values.

I'm unsure if a NULL value should be flagged as a validation error or not in the validate function. But I've replicated what the FormCalculationElement currently does.

Remaining tasks

Provide issue fork.

📌 Task

Status

Closed: cannot reproduce

Version

1.0

Component

Code

Created by

codebymikey

Live updates comments and jobs are added and updated live.

Merge Requests

!17Support "0" values without needing to specify a default value.
Open
codebymikey
updated 4 months ago

Comments & Activities

Issue created by @codebymikey
Merge request !17Issue #3464671: Support "0" values without needing to specify a default value → (Open) created by codebymikey
Status changed to Needs review 4 months ago12:47pm 30 July 2024
Comment 4 months ago →
codebymikey
Pipeline finished with Success
4 months ago
Total: 213s
#238378
Status changed to Closed: cannot reproduce 2 months ago9:15pm 17 September 2024
Comment 2 months ago →
🇧🇷Brazil joaopauloc.dev
I couldn't reproduce it, it probably was fixed in the new release.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024