Webform Calculation markup currently doesn't work with multiple expressions

Created on 30 July 2024, 4 months ago

Updated 17 September 2024, 2 months ago

Problem/Motivation

The validation fails when adding a Calculation Markup element to a Webform.

Steps to reproduce

Install "Webform UI" and the "Calculation Fields Example" submodule.

Edit the Webform Calculation fields multistep example "/admin/structure/webform/manage/webform_calculation_fields_multi" form, and add a new markup element with the following content:

Result: {{ :multiply_result / :to_divide }}

Calculation:
{{ :multiply_result }} / {{ :to_divide }} = {{ :multiply_result / :to_divide }}

On saving, the following error message is thrown:

The following field(s) (Result, Calculation) does not exists on the webform. Please check your expression!

Proposed resolution

The parser should only check the markup substituted elements for values.

Remaining tasks

It'd be nice if the markup calculation can handle multiple calculations within a single markup, but that doesn't seem to be supported at the moment. So depending on the scope of difficulty, this ticket can be extended to do that instead.

User interface changes

N/A

📌 Task

Status

Needs work

Version

1.0

Component

Code

Created by

codebymikey

Live updates comments and jobs are added and updated live.

Merge Requests

!16Webform Calculation markup currently doesn't work with multiple expressions
Open
codebymikey
updated 4 months ago

Comments & Activities

Issue created by @codebymikey
Merge request !16Issue #3464614: Validate webform calculation markups properly → (Open) created by codebymikey
Pipeline finished with Success
4 months ago
Total: 193s
#238145
Status changed to Needs review 4 months ago8:49am 30 July 2024
Comment 4 months ago →
codebymikey
Comment 4 months ago →
🇧🇷Brazil joaopauloc.dev
joaopauloc.dev → made their first commit to this issue’s fork.
Comment 4 months ago →
🇧🇷Brazil joaopauloc.dev
Hello @codebymikey, thanks for your contribution.
I'm going to review the module to add the support that you mentioned.
I agree that would be nice to have the support for that.
Thanks.
Comment 4 months ago →
🇧🇷Brazil joaopauloc.dev
Updating the title since the markup doesn't work only with multiple expressions in the markup content.
Status changed to Needs work 2 months ago9:17pm 17 September 2024
Comment 2 months ago →
🇧🇷Brazil joaopauloc.dev

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024