Added a new feature in the global site that allows you to disable all gaps and padding across all regions, except for menu regions

Created on 28 July 2024, 4 months ago
Updated 4 September 2024, 3 months ago

May I suggest offering more control over padding ?
I think it would be a good thing to include this in the settings, because overriding padding in the subtheme's CSS causes CLS.

I have several suggestions :
- differentiate between top/bottom and left/right padding in the options. I generally like to set left and right padding to 0 because nested page content and especially multi-nested content doesn't look great otherwise
- in general, offer a zero padding option
- offer padding options based on media queries, so the sitebuilder can specify padding options for full site width, intermediary and small screen sizes

thank you !

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @drupaldope
  • Status changed to Postponed: needs info 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    Hello,

    Thank you for your feedback. I will need more details about each feature. Maybe a video or detailed examples.

    Best wishes,
    Alaa

  • I will have more time later to give more examples, but let's start with this one from https://unitedstarsofamerica.com/

    On the picture you can see how content is not justified.

    Some designs will have no boxes/borders, so on a fixed width template, the design will call for justifying content to the left (and right) edge of content width, so that would be an example of left and right padding = 0.

  • another pic explaining better what I mean with "content"

  • here another example, this time about vertical padding.
    the attached screenshot show the lower right corner of a website.

    the google map block and the footer should be directly joined without spacing, as most other elements on websites I make.

    so in most cases, with the old D8W3CSS, I had to eliminate/override the dreaded w3css-padding which seemed to be applied to almost everything, or w3row-padding, etc.

    overriding it in style.css caused CLS, because the base css was loaded first.

    a solution could be to override the css librar(ies) responsible for the padding, but then this makes a re-work necessary every time a new version with new css comes out.

    so I instead had to include these styles inline with !important, which is a bit inefficient and causes "unused css" warnings in lighthouse.

    other use cases include using a block to show a header image, a flexslider slideshow, a background video, a picture as a design element within the page flow, etc.

    another example is how the pictures join on their corner on the screenshot (this uses paragraphs).

    these cases happen more often than not - I never had the case where the default paddings were what the designer wanted.

    the option to specify 0 padding would be useful, so sitebuilders could then just include/import custom CSS files from within the TWIG template so they get cached correctly.

    but maybe you have another/better way of achieving the same result.

    most of my experience comes from D8W3CSS, I didn't work much with SOLO so far.

    I think your work can be very significant for the Drupal project by making themeing accessible.
    Olivero might have been a good technical showcase and easy to use for advanced Drupal users, but Olivero forced design choices on the user and was difficult to use and customize for the average sitebuilder.
    The alternative is Bootstrap... 4 or 5.
    But here again, SASS, node.js, git... compiling styles... and maybe using some drush as well... Bootstrap is not for the average windows-based sitebuilder.

    themeing is one of the main obstacles why people don't use Drupal and one of the main reasons why corporations tend to use headless Drupal.

    Windows-based sitebuilders which want a simple but flexible, easily customizable, free and opensource Drupal theme do not have a lot of choices.

    Imagine a theme that would allow average windows-based sitebuilders (which don't use drush or node.js) to customize it into any desired appearance without sacrificing update compatibility and performance ?

  • Status changed to Active 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    Hello,

    Thank you for the explanation. I will have to think about something to help with padding. One solution to work around "Overriding it in style.css caused CLS because the base CSS was loaded first" is to override it in the sub-theme and ensure the CSS in the sub-theme comes before SOLO.

    The provided YAML configuration is for a Drupal sub-theme named "solo-subtheme-global." This configuration specifies how CSS and JavaScript files should be loaded for the sub-theme.

    solo-subtheme-global:
      Version: VERSION
      css:
        base:
          css/solo-subtheme-style.css: { weight: -400 }
      js:
        js/solo-subtheme-script.js: {}

    You can also define CSS classes in the sub-theme and then add these classes in the region settings in the CSS classes field. This is the same way I disabled the button animation.

    By using this configuration, you ensure that the custom CSS in solo-subtheme-style.css is loaded before the base CSS of the parent theme, thereby preventing CLS issues. This method allows for better control and customization of the theme's styling without causing layout shifts during page load.

    Best wishes,
    Alaa

  • that's good advice, thank you

  • Status changed to Fixed 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    Hello,

    A new feature in the global site "Website Region's Spaces" that allows you to disable all gaps and padding across all regions, except for menu regions.

    Best wishes,
    Alaa

  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX
  • πŸ‡§πŸ‡ͺBelgium ericvl

    I have a little remark here:
    I see that all instances of "gab" are replaces with "gap" in version 1.0.10 of the code.
    When I exported the configuration for the settings of my subtheme under 1.0.9 (with the wrong gab words in it) and imported these settings again in a 1.0.10 version, will this be OK?
    Thank you for a reaction on this.

    By the way: Great Theme.

  • πŸ‡ΊπŸ‡ΈUnited States flashwebcenter Austin TX

    Hello,

    I corrected the typo in version 1.0.10, but the variable did not change. If you have customized this setting on your site, you'll need to revisit the theme settings, reselect this option, and then click 'Save' and 'Import'. That's it.

    Whenever I update the theme, I usually review the page settings to ensure nothing has changed, then click 'Save' and 'Import' the configuration again. After that, I check the theme.settings file to see what has been modified.

    You're welcome! Thank you for the kind wordsβ€”I'm glad you like the theme! If you have any more feedback or questions, feel free to reach out.

    Best wishes,
    Alaa

  • πŸ‡§πŸ‡ͺBelgium ericvl

    @flashwebcenter
    Thank you for your clear explanation.
    I know, you have the capabilities of doing a good job.
    I was just wandering if you checked this.
    Thank uou
    Eric

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024