Only show rebuild permission messages to users who can access link

Created on 26 July 2024, 9 months ago

Problem/Motivation

Messages warning users that permissions may need to be rebuilt can be shown to users who cannot access the permission rebuild page. This may cause confusion and frustrations to users.

Steps to reproduce

Create a "User admin" role
Give the User admin the "administer users" permission
As a user with the role of "User admin", update any user's roles
After saving the user you should see the "Your changes have been saved. You may have to rebuild permissions for your changes to take effect." message
Clicking on the link to rebuild permissions gives you a 403 error

Proposed resolution

Check a user's permissions before adding the message.

Remaining tasks

Add permission check

User interface changes

Message will be hidden for users who cannot rebuild permissions.

API changes

None

Data model changes

None

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States averagejoe3000 Swanzey, NH

Live updates comments and jobs are added and updated live.

Merge Requests

!14Only show rebuild permission messages to users who can access link
Open
🇺🇸United States averagejoe3000
updated 9 months ago

Comments & Activities

Issue created by @averagejoe3000
Comment 9 months ago →
🇺🇸United States averagejoe3000 Swanzey, NH
Merge request !14Check rebuild form access before displaying link to form → (Open) created by averagejoe3000
Pipeline finished with Failed
9 months ago
Total: 172s
#235195
Pipeline finished with Failed
9 months ago
Total: 201s
#235203
Status changed to Needs work 3 months ago3:54pm 27 January 2025
Comment 3 months ago →
🇬🇧United Kingdom steven jones
@averagejoe3000 thanks for the work here.

I suppose that we should add a test to ensure that we don't show the message to someone who can edit the settings, but not rebuild the access permissions.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024