Logging is happening even with debugging off

Created on 26 July 2024, 3 months ago
Updated 10 August 2024, 2 months ago

Problem/Motivation

Under some cases, like a temporarily missing Memcache instance behind mcrouter, the module may start logging failures.

While logging is good, it can also be bad (when it's too much) and can clog up the Database or syslog logs.

The previous release's behavior was different; it seems there was a change in this line in the MemcachedDriver.php class:

8.x-2.5:

if (!$result && $this->settings->get('debug')) {

8.x-2.6: (wrong?)

if (!$result || $this->settings->get('debug')) {

There is no mention of this behavior change in the README so I'm flagging this as a bug.

Steps to reproduce

Don't have a set of steps, but I think we could create one by configuring a local Drupal so that only a single cache bin points to memcache, then stop the local memcache service, and run some drush snippet that tries to reach that. Or, this may need mcrouter as a middleman and then stop the backend memcache instance...?

Proposed resolution

Change || back to && above.

Remaining tasks

Create Merge request.

User interface changes

None

API changes

None

Data model changes

None

πŸ› Bug report
Status

Fixed

Version

2.6

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States janusman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024