- Issue created by @irina.povjakel
- Status changed to Needs review
8 months ago 9:24pm 31 July 2024 - 🇮🇹Italy itamair
Thanks a lot for reporting this ...
Definitely it looks we have a too much simplified way of generating Polygon data in the LeafletService, that is totally loosing / skipping possible holes in "out rings" (https://leafletjs.com/reference.html#polygon).I started inspecting this and already setup a tmp patch that looks re-enabling the rendering of holes in Polygons ... and that I attach here.
Please, try to QA and Review it.
In the meanwhile I will do the same, and check for potentials similar adjustments needed for Multi-Polygons, etc, so as will check for potential regressions and better refactoring. - 🇮🇹Italy itamair
New attached patch provides better code refactoring to more properly handle Multipolygons, still preserving & extending holes support (into Polygons)
- Status changed to Fixed
8 months ago 2:46pm 6 August 2024 - 🇮🇹Italy itamair
Patch #6 was deployed into the 10.2.x branch, and new Leaflet 10.2.23 release was deployed with all this.
Thanks @Irina.povjakel for your contribution and MR (that I am going yo close). Seems this path in D10 caused attached polygon not being rendered (map defaulted to 0,0 ) in View mode, but still rendering in Edit.
- 🇮🇹Italy itamair
all good with the polygons and multi polygons with new Leaflet module 10.2.23 ...
and also with your attached one (see the attached screenshot).Just make sure to clear the cache of your browser so that it refers and loads the new version of the js/leaflet.drupal.js file ...
(trying with private navigation helps on this) - 🇬🇧United Kingdom steven jones
@monkk / @itamair it might also be that because leaflet (incorrectly) sets the version of the library to VERSION, the changes to the library files are not picked up by visitors.
VERSION should only really be used for core, and not by contrib.
I'll open an issue for this if there's not already one against the project.
Automatically closed - issue fixed for 2 weeks with no activity.