PHP warning when viewing a registrant without first / last name fields

Open on Drupal.org →

Created on 26 July 2024, 9 months ago

Problem/Motivation

When viewing a registrant that doesn't have a first name or last name field, the following warning is emitted:

Warning: Attempt to read property "value" on null in Drupal\recurring_events_registration\Controller\RegistrantController->getTitle() (line 118 of modules/contrib/recurring_events/modules/recurring_events_registration/src/Controller/RegistrantController.php).

Steps to reproduce

Create a registrant type that does not have a first name or last name field. As an example: a site might host events intended for classes of school children. Requiring a first or last name doesn't make sense in this context.
Register for an event.
View the registrant in the backend/

Proposed resolution

Instead of hardcoding a title that assumes the optional field_first_name and field_last_name fields are always going to be retained by all users, let's just display the label. This is configurable by the site builder in the Registrant Settings under Registrant Display > Registrant Title.

User interface changes

In sites that use default settings, the title of the registrant page will change from "first name + last name" to the email address. This change is probably not going to have much impact for most users and now respects the title as configured by the site builder.

🐛 Bug report

Status

Active

Version

2.0

Component

Recurring Events Registration (Submodule)

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!101PHP warning when viewing a registrant without first / last name fields
Merged
🇧🇬Bulgaria pfrenssen
updated 6 months ago

Comments & Activities

Issue created by @pfrenssen
Merge request !101PHP warning emitted when accessing registrant page → (Merged) created by pfrenssen
Pipeline finished with Failed
9 months ago
Total: 173s
#234879
Comment 9 months ago →
🇧🇬Bulgaria pfrenssen Sofia
Added a test to the MR that showcases the PHP warning (ref https://git.drupalcode.org/issue/recurring_events-3463979/-/jobs/2240107)

There was 1 error: 1) Drupal\Tests\recurring_events_registration\Kernel\RegistrantControllerTest::testGetTitle Attempt to read property "value" on null
In order to make the test executable I had to update the config schema of the module. I can split this off to a separate issue if desired.
Pipeline finished with Success
9 months ago
#234891
Status changed to Needs review 9 months ago2:32pm 26 July 2024
Comment 9 months ago →
🇧🇬Bulgaria pfrenssen Sofia
Applying the fix turns the test green! Ready for review :)
Pipeline finished with Skipped
6 months ago
#296327

Comment 6 months ago →

pfrenssen → committed 0ed2946c on 2.0.x

Issue #3463979: PHP warning when viewing a registrant without first /...

Comment 6 months ago →

pfrenssen → committed 0ed2946c on 3.0.x

Issue #3463979: PHP warning when viewing a registrant without first /...

Comment 6 months ago →
🇧🇬Bulgaria pfrenssen Sofia
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024