Contrib.social

Invalid if statement in CronFrequencyValidator

Open on Drupal.org →
Created on 25 July 2024, 8 months ago
Updated 8 August 2024, 8 months ago

Problem/Motivation

CronFrequencyValidator has this line:

    // We only want to do this check if the stage belongs to Automatic Updates.
    if (!$event->stage->getType() === 'automatic_updates:unattended') {
      return;
    }

This is a copypasta mistake from when stage types were checked by instanceof.

Proposed resolution

Change it to:

    // We only want to do this check if the stage belongs to Automatic Updates.
    if ($event->stage->getType() !== 'automatic_updates:unattended') {
      return;
    }

This is so straightforward that if tests pass, I'm going to merge it outright.

🐛 Bug report
Status

Fixed

Version

3.1

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024