- Issue created by @catch
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Yeah this is the arguments... let's fix it.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Hmmm... I've used the same string locally and it runs... added more detail to the runs and the skip is happening due to:
The test wasn't able to connect to your webdriver instance. For more information read core/tests/README.md. The original message while starting Mink: Could not open connection: Could not start a new session. Error while creating session with the driver service. Stopping driver service: Driver server process died prematurely. Build info: version: '4.22.0', revision: 'c5f3146703' System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.1.66-93.164.amzn2023.x86_64', java.version: '17.0.11' Driver info: driver.version: unknown Host info: host: '3ad2463107b7', ip: '192.168.160.3' Build info: version: '4.22.0', revision: 'c5f3146703' System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.1.66-93.164.amzn2023.x86_64', java.version: '17.0.11' Driver info: driver.version: unknown
Feel like I'm missing something simple.
- 🇬🇧United Kingdom catch
One possible difference between this and the usual runner is that the performance-test runner uses docker whereas the main runners use k8s. Pretty sure this is why we point to localhost instead of the image name.
However we went through all of that before, so no idea why changing the image would break it now and I can't see a problem with the arguments being sent.
I tried adding --shm-size=2g because not having that had broken things locally for me, and it might have been a difference between docker and k8s, but that also hasn't helped. (https://git.drupalcode.org/project/drupal/-/jobs/2220842 is the most recent run).
- Status changed to Needs review
about 1 month ago 1:29am 25 July 2024 - 🇬🇧United Kingdom catch
Put up an additional MR that moves the performance test back to the legacy driver:
https://git.drupalcode.org/project/drupal/-/jobs/2221126
I think we should do that, then open a follow-up (or maybe continue here for the commit history on the MR) to figure out how to get things onto selenium standalone. Also noticed the test only job is still using the legacy driver which I assume was an oversight in the original issue, so we should move that one too (although that'll be on k8s so should be straightforward).
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
The tests are failing in the right way - they are missing the OTEL_COLLECTOR env variable that is set in the schedule. So the revert to use chromedriver will work fine. Created 📌 Move performance test to selenium Active to fix this.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
alexpott → changed the visibility of the branch 3463534-legacy-for-now to hidden.
- Status changed to RTBC
about 1 month ago 8:18am 25 July 2024 - 🇬🇧United Kingdom longwave UK
Yep let's land this for now and fix in a followup.
- Status changed to Fixed
about 1 month ago 8:20am 25 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.