- Issue created by @alexpott
- Status changed to Postponed
about 2 months ago 9:13am 23 July 2024 - Status changed to Active
about 2 months ago 9:01am 24 July 2024 - 🇬🇧United Kingdom catch
It will be easier to see the impact of this and maybe bring concurrency down once 📌 Consolidate ckeditor5's FunctionalJavascript tests Needs review and 📌 Consolidate Umami performance tests Fixed are done, because those tests artificially extend the job times of the first two jobs with or without the w3c change.
- 🇬🇧United Kingdom catch
Pretty sure this isn't a problem with performance of the tests/driver as such but a race condition with test concurrency and the limit of 5 selenium sessions while concurrency is at 16 leading to race conditions/stampedes, various details in 📌 [PP-1] Order tests by number of public methods to optimize gitlab job times Postponed .
- Status changed to Needs work
about 1 month ago 8:16am 5 August 2024 - 🇬🇧United Kingdom catch
Will be harder to see the impact without all the other changes on 📌 [PP-1] Order tests by number of public methods to optimize gitlab job times Postponed but I've started moving the relevant changes here - going to do the three changes commit by commit in case anything goes weird with the pipelines.
- 🇬🇧United Kingdom catch
Commit 1: increasing max sessions- all four functional js test runs finish in under 3 minutes each:
https://git.drupalcode.org/project/drupal/-/jobs/2340496
https://git.drupalcode.org/project/drupal/-/jobs/2340497
https://git.drupalcode.org/project/drupal/-/jobs/2340498
https://git.drupalcode.org/project/drupal/-/jobs/2340499 - 🇬🇧United Kingdom catch
Commit 2:
No obvious difference compared to commit 1:
https://git.drupalcode.org/project/drupal/-/jobs/2340581
https://git.drupalcode.org/project/drupal/-/jobs/2340582
https://git.drupalcode.org/project/drupal/-/jobs/2340583
https://git.drupalcode.org/project/drupal/-/jobs/2340584 - 🇬🇧United Kingdom catch
Commit 3, two parallel jobs and also half the concurrency:
https://git.drupalcode.org/project/drupal/-/jobs/2340645
https://git.drupalcode.org/project/drupal/-/jobs/23406463m30 and 3m50 - this is about what we were seeing before the selenium switch, the overall time is improved by 📌 [PP-1] Order tests by number of public methods to optimize gitlab job times Postponed .
- Status changed to Needs review
about 1 month ago 8:34am 5 August 2024 - Status changed to RTBC
about 1 month ago 10:35am 5 August 2024 -
longwave →
committed eedde808 on 11.x
Issue #3463286 by catch: Fix selenium performance/stampede issues in...
-
longwave →
committed eedde808 on 11.x
- Status changed to Fixed
about 1 month ago 4:11pm 6 August 2024 - 🇬🇧United Kingdom longwave UK
Committed eedde80 and pushed to 11.x. Thanks!
This needs porting over to the backport in 📌 Use selenium/standalone-chrome instead of our chromedriver image Needs work now.
Automatically closed - issue fixed for 2 weeks with no activity.