- Issue created by @alexj12
- Merge request !10Introduce arguments to govuk_notify.notify_service service defintion → (Open) created by alexj12
- Issue was unassigned.
- Status changed to Needs review
11 months ago 9:16am 22 July 2024 - 🇬🇧United Kingdom Eli-T Manchester
Hey @Alexj12! Thanks for the fix.
I'm just wondering whether this is the right thing to do here - I'm not sure why the submodule redeclares an identical service as the parent module.
Can we just remove the modules/govuk_notify_views_backend/govuk_notify_views_backend.services.yml file?
- 🇬🇧United Kingdom Eli-T Manchester
In fact I think that's what we already propose to do in 📌 Fix PHPstan issues Active
- Status changed to Closed: won't fix
about 2 months ago 3:14pm 18 April 2025 - 🇬🇧United Kingdom Eli-T Manchester
Hi! I'm closing this as I don't think we need it since 📌 Fix PHPstan issues Active was merged. But please feel free to open it again if you think it's still needed.