- Issue created by @pfrenssen
- Status changed to Needs work
5 months ago 10:22am 19 July 2024 - 🇦🇺Australia darvanen Sydney, Australia
This fails phpcs standards unfortunately. There has to be another way.
This looks more like a bug with how the graphQL module parses Annotations. I think the easiest thing will be to shorten the description so the whole line stays within the 80char limit.
- 🇧🇬Bulgaria pfrenssen Sofia
Annotations are allowed to go over 80 characters, see example at Coding standards for @Annotation and @Plugin discovery → .
- Status changed to Postponed
5 months ago 1:49pm 19 July 2024 - 🇧🇬Bulgaria pfrenssen Sofia
Ah so the Coder module gives a false positive on this, I created a bug report: 🐛 Translated strings in annotations are allowed to exceed 80 characters Active . Let's postpone this until it is fixed.
We can also set the coding standards check to be mandatory, that would be helpful moving forward to ensure they are being honored.
- Status changed to Needs review
5 months ago 2:07pm 19 July 2024 - 🇧🇬Bulgaria pfrenssen Sofia
Actually the problem was that our label and description was not marked as translatable. Now the coding standards check passes!
- 🇦🇺Australia darvanen Sydney, Australia
Ah fabulous, thank you for that!
Yes I agree making them mandatory is useful.
- Status changed to RTBC
5 months ago 1:53am 20 July 2024 -
darvanen →
committed e8fb8926 on 2.x authored by
pfrenssen →
Issue #3462582 by pfrenssen, darvanen: Remove stray asterisk from...
-
darvanen →
committed e8fb8926 on 2.x authored by
pfrenssen →
- Status changed to Fixed
5 months ago 1:53am 20 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.