Support Address 2.x

Created on 18 July 2024, 5 months ago
Updated 9 August 2024, 5 months ago

Problem/Motivation

The Address module has released a new major version 2.x. Let's support it in addition to the legacy 1.x branch.

Feature request
Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @pfrenssen
  • 🇦🇺Australia darvanen Sydney, Australia

    Absolutely. Do you think it can be done in the same code or do we need to start a new major to support it?

  • Assigned to pfrenssen
  • 🇧🇬Bulgaria pfrenssen Sofia

    I am going to try it out today. I reviewed the diff between Address 1.12 and 2.0.0 and there differences are minimal. The API remains unchanged apart from some very minor differences which will probably not affect us. The data model has had an addition of a new column "address_line3".

    A new major version is probably not necessary.

  • Merge request !13Resolve #3462446 "Support address 2.x" → (Merged) created by pfrenssen
  • Pipeline finished with Success
    5 months ago
    Total: 137s
    #228709
  • Status changed to Needs review 5 months ago
  • 🇧🇬Bulgaria pfrenssen Sofia

    Simply adding the new field works fine. I've tested it with both Address 1.12.0 and 2.0.2. When using Address v1, the field will simply always return NULL.

  • Status changed to RTBC 5 months ago
  • 🇦🇺Australia darvanen Sydney, Australia

    Nice one! Thank you very much.

    Based on you covering off the only issue I can think of ocurring I'm going to commit this, the code is good. Would love a test but I think that can be a follow-up.

  • Pipeline finished with Skipped
    5 months ago
    #234348
  • Status changed to Fixed 5 months ago
  • 🇦🇺Australia darvanen Sydney, Australia
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024