- Issue created by @alexpott
- Status changed to Needs review
10 months ago 8:01am 18 July 2024 - 🇬🇧United Kingdom catch
This looks great, do we want to do the other REST tests that skip on the XML format?
Looks like at least these:
UserXmlCookieTest UserXmlAnonTest UserXmlBasicAuthTest UserXmlCookieTest WorkspaceXmlBasicAuthTest WorkspaceXmlAnonTest WorkspaceXmlCookieTest core/modules/taxonomy/tests/src/Functional/Rest/TermXmlBasicAuthTest.php core/modules/taxonomy/tests/src/Functional/Rest/TermXmlCookieTest.php core/modules/taxonomy/tests/src/Functional/Rest/TermXmlAnonTest.php core/modules/image/tests/src/Functional/Rest/ImageStyleXmlAnonTest.php core/modules/image/tests/src/Functional/Rest/ImageStyleXmlCookieTest.php core/modules/image/tests/src/Functional/Rest/ImageStyleXmlBasicAuthTest.php core/modules/node/tests/src/Functional/Rest/NodeXmlAnonTest.php core/modules/node/tests/src/Functional/Rest/NodeXmlBasicAuthTest.php core/modules/node/tests/src/Functional/Rest/NodeXmlCookieTest.php core/modules/rest/tests/src/Functional/EntityResource/ModeratedNode/ModeratedNodeXmlAnonTest.php core/modules/rest/tests/src/Functional/EntityResource/ModeratedNode/ModeratedNodeXmlCookieTest.php core/modules/rest/tests/src/Functional/EntityResource/ModeratedNode/ModeratedNodeXmlBasicAuthTest.php
I think we can also use the same pattern in:
jsonapi/tests/src/Functional/FileUploadTest.php
and similar too, probably better in its own issue though.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
The MR takes us to only 7 functional test methods being skipped that actually take longer than 0.00 seconds! Down from over hundred...
I think this is ready for review.
- Merge request !8817Resolve #3462264 "Xmlentitynormalizationquirkstrait skips testpatch 10.4.x" → (Closed) created by alexpott
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Added an MR to backport this to 10.x using the annotation for before instead of the attribute.
- Status changed to RTBC
10 months ago 11:23am 18 July 2024 - 🇬🇧United Kingdom catch
Hard to see what the impact on pipeline wall times is going to be due to variation between test runs, but even if it only takes 10 seconds to install Drupal, ~100 less installs is 1000 seconds less test time. There are also some specific tests (like file upload ones) which have been some of the most individually long running tests that this should help with too.
Committed/pushed the respective MRs to 11.x/11.0.x/10.4.x, 10.3.x, thanks!
- Status changed to Fixed
10 months ago 11:36am 18 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.