- Issue created by @Charlie ChX Negyesi
- πΊπΈUnited States nicxvan
Is there an upstream issue for this? I can't find one.
- Status changed to Needs review
3 months ago 4:53pm 28 December 2024 - π¦πΉAustria klausi π¦πΉ Vienna
Thanks, please create pull requests at https://github.com/pfrenssen/coder/pulls so that we see tests run there.
- πΊπΈUnited States nicxvan
Done! I'm not sure what is needed for tests here, but I just moved it over.
Also not sure if I should still use statuses here.
- π¦πΉAustria klausi π¦πΉ Vienna
Thanks a lot! Yes, we use statuses here and assign credits here.
Approach makes sense, only the test case needs to be moved to the right place.
-
klausi β
committed 8339bd5b on 8.3.x
test(ScopeIndent): Fix PHP attribute error lines (#3461148)
-
klausi β
committed 8339bd5b on 8.3.x
- acc55a98 committed on 8.3.x
fix(ScopeIndent): Support PHP attributes (#3461148 by nicxvan)
- acc55a98 committed on 8.3.x
- π¦πΉAustria klausi π¦πΉ Vienna
Merged, thanks! Tests were failing, fixed them in a small follow-up.
Please always run the test cases to verify they are correct.
-
klausi β
authored bf0dc2f5 on 8.3.x
fix(ScopeIndent): Fix test fails on attributes on constructor promotion...
-
klausi β
authored bf0dc2f5 on 8.3.x
- π¦πΉAustria klausi π¦πΉ Vienna
Turns out that this broke Drupal core testing. I need to really wait for full green tests on Github before merging next time.
Fixed this by updating the sniff from upstream in https://github.com/pfrenssen/coder/pull/245
Automatically closed - issue fixed for 2 weeks with no activity.