- Issue created by @cbccharlie
- Issue was unassigned.
- 🇩🇪Germany jurgenhaas Gottmadingen
Hmm Drush 11 is EOL since November last year. Why not upgrading to Drush 12?
- 🇪🇸Spain cbccharlie
Yes, that's correct. In the issue title I indicated 11, but I was referring to 11+, that is, 11 and 12.
I'm reassigning the issue to myself, because I have it fixed and I'm going to create the MR soon.
- Assigned to cbccharlie
- Issue was unassigned.
- Status changed to Needs review
6 months ago 9:42am 10 July 2024 -
jurgenhaas →
committed f59aa799 on 4.1.x
Issue #3459899 by cbccharlie, jurgenhaas: Add Drush 11 compatibility
-
jurgenhaas →
committed f59aa799 on 4.1.x
- 🇩🇪Germany jurgenhaas Gottmadingen
@cbccharlie the usage of the
drushsevices.yml
file is deprecated and not required by Drush 12 and later.However, I just noticed there has been a different issue that prevented Drush from discovering the commands: the class name must end with
Commands
. I've fixed that in the dev branch. Please have a look. -
jurgenhaas →
committed c7c11e06 on 4.1.x
Issue #3459899 by cbccharlie, jurgenhaas: Add Drush 11 compatibility
-
jurgenhaas →
committed c7c11e06 on 4.1.x
- 🇪🇸Spain cbccharlie
@jurgenhaas, sorry, I didn't know that drush.services.yml is no longer necessary.
And yes, with the DEV changes it now discovers the Drush command :).
On the other hand, I had applied a small change when executing the command, so that it shows in the console the URL that needs to be loaded in DRD to finish configuring the agent. Do you see it correctly? You can see it in the MR that I had created.
Thank you very much!
- Status changed to Needs work
6 months ago 11:00am 10 July 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
I had applied a small change when executing the command, so that it shows in the console the URL that needs to be loaded in DRD to finish configuring the agent.
That's a good idea, but it needs a bit more work. Could you please rebase the MR so that it contains the changes from the dev branch and then make sure that it tests first that
$values['redirect']
exists? If it doesn't, an error message should be reported, otherwise the success message should explain what to do with the printer redirect URL. - Status changed to Needs review
6 months ago 11:54am 10 July 2024 -
jurgenhaas →
committed 7878b86d on 4.1.x authored by
cbccharlie →
Issue #3459899: Display the url to finish agent configuration using...
-
jurgenhaas →
committed 7878b86d on 4.1.x authored by
cbccharlie →
- Status changed to Fixed
6 months ago 7:31am 11 July 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
This is great, thank you very much for your contribution.
Automatically closed - issue fixed for 2 weeks with no activity.