Loosen the requirements check for TTL below one month

Created on 5 July 2024, 4 months ago
Updated 30 August 2024, about 2 months ago

Problem/Motivation

The status report shows a warning "TTL settings under a month are not recommended, the longer you set it, the better your site will perform!" if your TTL is lower than 32 days. There are 4 months with 30 days, 7 months with 31 days and one month with 28 or 29 days, but no months with 32 days. Since the definition of a month is fairly loose I think we should consider a TTL >= 28 days to be close enough to a month.

Steps to reproduce

Set TTL to 2419200 (28 days), or 2678400 (31 days). See status report.

Proposed resolution

Update requirements check to < 2419200.

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Needs review

Version

3.0

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mstrelan
  • Merge request !45Update requirements → (Open) created by mstrelan
  • Status changed to Needs review 4 months ago
  • Pipeline finished with Success
    4 months ago
    Total: 1430s
    #216226
  • 🇫🇷France O'Briat Nantes

    This checks values (24h, one month, one year) seem very strange if not dangerous.

    $this->config->get('cache.page.max_age') is the value that Drupal use as max-age in the cache-control header of the response send to the client.
    This value will be used by reverse proxy such as Varnish but also by the client browser which could not be purged by Drupal.

    Could someone explain these choices?
    Do you rely on conditional request header (If-None-Match, ...)?

  • 🇫🇷France O'Briat Nantes

    See also "Cache Max Age warning text"

Production build 0.71.5 2024