Allow percentage in iframe width and height

Created on 4 July 2024, 6 months ago

Problem/Motivation

A percentage needs to be applied to the iframe width. The plugin "modules/contrib/ckeditor_iframe/js/ckeditor5_plugins/iframeembed/src/iframeEmbedFormView.js" has the "isNumber" parameter of the createInput method set to "true", so values other than digits are not allowed to be entered.

Steps to reproduce

Create an iframe and try to enter in the "width" property the value 100%.

Proposed resolution

Remove the "true" parameter from the above-mentioned createInput method, since by default the value is false.

✨ Feature request

Status

Active

Version

3.0

Component

Code

Created by

🇪🇸Spain alvolvfdez

Live updates comments and jobs are added and updated live.

percentage

Merge Requests

!10Allow percentage in iframe width and height
Open
🇪🇸Spain alvolvfdez
updated 5 days ago

Comments & Activities

Issue created by @alvolvfdez
Merge request !10Issue #3458998: Allow percentage in width and length attributes → (Open) created by alvolvfdez
Status changed to Needs review 6 months ago12:28pm 4 July 2024
Comment 6 months ago →
🇪🇸Spain alvolvfdez
Comment 5 months ago →
🇫🇷France lazzyvn paris
and can we set 100% if the width is not filled?
Comment 2 months ago →
🇮🇳India santoshparbat
Hi @alvolvfdez,

Just wanted to update you that your changes are not applying to ckeditor_iframe 3.0.0-beta2.

Thanks,
First commit to issue fork.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024