- Issue created by @taraskorpach
- Status changed to Active
9 months ago 7:37am 6 July 2024 - Status changed to Needs review
9 months ago 11:01am 8 July 2024 - πΊπ¦Ukraine taraskorpach Lutsk πΊπ¦
I've added an MR, but here are some errors with unit tests.
Unfortunately, I don't know how to handle the Solr instance requirement during PHPUnit tests. I'll let you figure it out :)
- Status changed to Needs work
9 months ago 9:45am 9 July 2024 - π©πͺGermany mkalkbrenner π©πͺ
From our project page and README:
Our test suite includes integration tests that require a real Solr server. This
requirement can't be provided by the drupal.org test infrastructure.
Therefore we leverage travis and github actions for our tests and had to establish a more complex workflow:- open an issue on drupal.org as usual
- upload the patch for being reviewed to that issue on drupal.org as usual
- fork https://github.com/mkalkbrenner/search_api_solr
- apply your patch and file a PR on github
- add a link to the github PR to the drupal.org issue
The PR on github will automatically tested by travis or github actions and the test results will
be reflected in the PR conversation. - Status changed to Needs review
9 months ago 11:08am 15 July 2024 - πΊπ¦Ukraine taraskorpach Lutsk πΊπ¦
Sorry for my ignorance :)
I've added a new PR on github.
Attaching a patch here as well. - Status changed to Fixed
9 months ago 10:10pm 24 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.