Contrib.social

Remove Lightning Scheduler submodule and move people to the separate contrib module with the same name instead

Open on Drupal.org →
Created on 2 July 2024, 9 months ago

Problem/Motivation

Back then Lightning Scheduler → was also added as a separate module to drupal.org with removed dependencies to Lightning modules. This means technically, we have the same module in 2 places. This is confusing everyone. Now, there are a few critical and major problems that were fixed in the separate module that are missing from the submodule version:
- 🐛 Circular reference detected for service "cache.backend.database". Active
- 🐛 Error: Call to undefined function drupal_get_path() in lightning_scheduler_library_info_alter() Needs review
- 🐛 Creation of dynamic property Drupal\lightning_scheduler\Time::$_serviceId is deprecated RTBC

So now you can see already that it is not viable to maintain the same module and fixing the same bugs in 2 places.

Steps to reproduce

Proposed resolution

- Remove the Lightning Scheduler submodule completely in a new major version
- Add an upgrade path, so that people during upgrading should require the drupal/lightning_scheduler module via composer and clear the caches. Maybe the same way could be done to how the 3.x -> 4.x upgrade was with dropping dependencies.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Active

Version

4.0

Component

Code

Created by

🇸🇰Slovakia kaszarobert

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kaszarobert
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇺🇸United States timwood Rockville, Maryland

    Attached is a patch for the 4.0.x dev branch and 4.0.0 release version that both remove the lightning_scheduler sub-module and update the README.md to remove the reference to that.

  • Comment 3 months ago →
    🇸🇰Slovakia kaszarobert

    As a workaround, I created a new branch of Lightning Workflow that removes the Lightning Scheduler Module and creates a dependency on that contrib project.

    See the 5.x branch.

    According to https://www.drupal.org/project/lightning_workflow/issues/3457016#comment... 🐛 Circular reference detected for service "cache.backend.database". Active we should use the 5.0.x-dev version → now instead of patching. Still, a proper stable release would be the best.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024