- Issue created by @tedbow
- Issue was unassigned.
- Status changed to Needs review
6 months ago 6:17pm 2 July 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
Marking this as Critical as blocks π [PP-1] Add support for matching SDC prop shape: {type: string, enum: β¦} Postponed which is critical
- Assigned to tedbow
- Status changed to Needs work
6 months ago 9:20am 5 July 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
- What does "all β¦ are not found" mean? π€ Do you mean "not all β¦ are found"?
- This is indeed a tricky area, which is why there's this:
// @todo Field item-level indirect vs direct constraints should not override each other. Investigate in Drupal core, this seems to be an oversight? // Field item-level constraints override property-level constraints.
β¦ because AFAICT Drupal core somehow does not (yet) provide infrastructure for this π€―
- RE: points in issue summary:
- Correct, "always using the first element" is what I discovered (during a deep debugging session) Drupal core always does β¦ but now I wish I had added a comment pointing to where in Drupal core that is happening π¬
- Excellent remark β I didn't discover that edge case at all, but you're right that it's absolutely possible. We should at minimum add an
assert()
that verifies there's an empty intersection, and when we find the first non-empty case, we should match Drupal core's existing behavior. Ideally, Drupal core should provide an API for this β¦ - I'm fine with that simplification β I see that
FieldItemBase::getConstraints()
also promises this, so I have no idea why I did that. Probably defensive programming? π€·ββοΈ
- Issue was unassigned.
- Status changed to RTBC
6 months ago 12:02pm 5 July 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
If after this docs + logic improvement, π [PP-1] Add support for matching SDC prop shape: {type: string, enum: β¦} Postponed is still blocked, please open a new issue with a failing test case to show what the precise blocker is. This represents a step forward, so I'm going ahead and am merging this.
-
Wim Leers β
committed 373966b1 on 0.x authored by
tedbow β
Issue #3458580 by tedbow, Wim Leers: Document in great detail where...
-
Wim Leers β
committed 373966b1 on 0.x authored by
tedbow β
- Status changed to Fixed
6 months ago 12:40pm 5 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.