[10.3 Regression] Menu containing language switcher link non-editable

For further context, the issue is also related to me unsetting the current language in a hook_language_switch_links_alter(). If I do not unset the current language the problem disappears, but then the current language is visible which is what I wanted to avoid.

Thanks for filing the issue. I didn't yet have the chance to look at it, but just a few questions from reading the IS and your comment:

1. Did you use that same alter hook and the module on 10.2 without problems?
2. Could you maybe share the code of the alter hook? I'm assuming it is fairly simple, but it might be easier to reproduce, if I can just reuse your implementation instead of writing my own.
3. Could you share the exact error message (and possibly a stack trace, but that is not really necessary) that you get when you try to edit the menu?

Thanks for the questions. Here are the answers:

1. Yes, the alter hook worked on 10.2 without problems
2. Here is the alter hook:

function my_module_language_switch_links_alter(array &$links, $type, \Drupal\Core\Url $url) {
  $current_language = \Drupal::languageManager()->getCurrentLanguage()->getId();
  unset($links[$current_language]);
}

3. Here is the error and stack trace:

The website encountered an unexpected error. Try again later.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 208 of core/lib/Drupal/Core/Routing/RouteProvider.php).

Drupal\Core\Routing\UrlGenerator->getRoute('') (Line: 132)
Drupal\Core\Routing\UrlGenerator->getPathFromRoute('', Array) (Line: 71)
Drupal\Core\Render\MetadataBubblingUrlGenerator->getPathFromRoute('', Array) (Line: 808)
Drupal\Core\Url->getInternalPath() (Line: 137)
Drupal\Core\Utility\LinkGenerator->generate('English', Object) (Line: 102)
Drupal\Core\Render\Element\Link::preRenderLink(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 870)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 504)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array) (Line: 475)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 182)
__TwigTemplate_750efad714b8da68ad259b30d7ec4b74->doDisplay(Array, Array) (Line: 360)
Twig\Template->yield(Array) (Line: 335)
Twig\Template->render(Array) (Line: 38)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('themes/contrib/gin/templates/dataset/table.html.twig', Array) (Line: 348)
Drupal\Core\Theme\ThemeManager->render('table', Array) (Line: 491)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 504)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 504)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 238)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 239)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Thanks. I just setup GitLab CI and just looking at the pipeline I can see that tests passed on 10.2, but are broken on 10.3. Bumping to critical.

Working on a fix.

Okay, I spoke too soon. Looks like the test failure is only due to the intentional behavior change in core in 10.3 that was introduced in 🐛 [regression] Do not bypass route access with 'link to any page' permissions for menu links Fixed . Previously, links linking to <current> were visible to users with permission to link to any page, now they're not. Since we're modifying access checks for this route, we're testing that the core behavior for any links not generated by our module is unchanged, so this failed. Once I modified these tests to reflect the intended change in behavior, the rest of the tests pass on 10.3, which means that the functionality of the module per se is unaffected by this change. So this is not actually as critical as I thought when seeing the test results. Back to normal.

I'm pushing a fix for the tests on 10.3 including two fixes for deprecated code that was also caught by the test run. This will bump the minimum core version to 10.1.

Still going to look into this.

FeyP → credited dshields → .

Crediting @dshields here for filing an issue and providing a wip patch over in 🐛 Drupal 10 compatibility Closed: duplicate about one of the deprecated code pathes we call that I just fixed in the MR as part of this issue.

Pushed a test for the problem reported here, the tests pass in 10.2 and fail on 10.3, 10.4 and 11, as can be seen here: https://git.drupalcode.org/project/language_switcher_menu/-/pipelines/22...

I just pushed the fix for the issue, which is pretty simple. If there is no link for a LanguageSwitcherLink, we now return <nolink> as a route name instead of an empty string. With this one line fix, we pass the new test.

@lelkneralfaro It would be great, if you could confirm, if the MR resolves your problem. Thanks.

Just looked at the code again and with the new tests based on comment #4 I'm confident that this works as intended. So I'm going to RTBC and then merge this. I'll let you know when I create a new release.

@lelkneralfaro Feel free to open a new issue, if you still have problems after this has been merged and released. Thanks again.

Adjusting issue title

Merged.

Released as part of 1.0.0-beta6.

Automatically closed - issue fixed for 2 weeks with no activity.